Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1387 Implement identity endpoints #5

Merged
merged 6 commits into from
Nov 22, 2023
Merged

feature/mx-1387 Implement identity endpoints #5

merged 6 commits into from
Nov 22, 2023

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 9, 2023 •
edited
Loading

  • new endpoint for fetching existing identities
  • and new endpoint for assigning (new/existing) ids

@cutoffthetop cutoffthetop self-assigned this Nov 9, 2023
@cutoffthetop cutoffthetop marked this pull request as ready for review November 16, 2023 14:19
@mr-kamran-ali mr-kamran-ali self-requested a review November 20, 2023 09:09
mr-kamran-ali
mr-kamran-ali reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coudn't find anything major. Just tiny things:

There is a deprecation warning on @app.on_event("shutdown") at line 120 in main.py

mex/backend/identity/main.py Show resolved Hide resolved
@cutoffthetop
Copy link
Contributor Author

There is a deprecation warning on @app.on_event("shutdown") at line 120 in main.py

fixed in d95ba20

@cutoffthetop cutoffthetop force-pushed the feature/mx-1387-identity-endpoints branch from 2de1cbe to d95ba20 Compare November 21, 2023 17:39
@cutoffthetop cutoffthetop merged commit 64186d4 into main Nov 22, 2023
3 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1387-identity-endpoints branch November 22, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-kamran-ali mr-kamran-ali mr-kamran-ali approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @mr-kamran-ali