Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/configure ruff for faster linting #32

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Oct 11, 2023

  • ruff is a new do-it-all-linter project written in rust (also used by the pydantic project)
  • even with additional checks, this speeds up our pre-commit hooks by 30%
  • also allows us to use toml for more configuration and requires less ini/cfg files

@cutoffthetop cutoffthetop self-assigned this Oct 11, 2023
@mr-kamran-ali mr-kamran-ali self-requested a review October 12, 2023 08:05
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean but, I feel like there are plenty of # noqa: __, more than our older linting setup. Do you think its still worth using ruff?

@cutoffthetop
Copy link
Contributor Author

Looks nice and clean but, I feel like there are plenty of # noqa: __, more than our older linting setup. Do you think its still worth using ruff?

the additional noqa comments are just because we check for a lot more linting rules now than before. but it's still good to be alerted and take a second to think about, whether there is a different way to write something, or why the rule should not apply to a particular section

@cutoffthetop cutoffthetop merged commit 57a7734 into main Oct 16, 2023
@cutoffthetop cutoffthetop deleted the feature/ruff branch October 16, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants