Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mx 1332 organigram check for duplicates #324

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Feature/mx 1332 organigram check for duplicates #324

merged 9 commits into from
Nov 12, 2024

Conversation

esinsj
Copy link
Contributor

@esinsj esinsj commented Nov 7, 2024 •
edited by cutoffthetop
Loading

Added

  • organigram extraction checks for duplicate emails/labels in different organigram units

cutoffthetop
cutoffthetop requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean! just a docstring fix, a test and a main-merge missing

mex/common/organigram/extract.py Outdated Show resolved Hide resolved
mex/common/organigram/extract.py Outdated Show resolved Hide resolved
tests/organigram/test_extract.py Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit 1e62cc3 into main Nov 12, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1332-organigram-check-for-duplicates branch November 12, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@esinsj esinsj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esinsj @cutoffthetop