Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mx-1387 update identity provider with assign method #34

Merged
merged 11 commits into from
Nov 3, 2023

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Oct 17, 2023

  • replace mex.common.identity.query functions with ~.registry
    • register_provider(...) allows mex-extractors and mex-backend to register their own IdentityProvider implementations
    • get_provider() gets an instance of the currently configured id provider
  • update function signatures of BaseProvider to cut sqlite ties
  • rename dummy provider to memory
  • deprecate mex.common.models.base.FlatValueMap - that was dead code
  • deprecate the bw-compatible properties of mex.common.identity.models.Identity - like merged_id
    • we need to use their proper names now (that comply with mex-model) - like stableTargetId

@cutoffthetop cutoffthetop self-assigned this Oct 17, 2023
@cutoffthetop cutoffthetop marked this pull request as ready for review October 27, 2023 13:07
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, like in code documentation and explanations. But ticket ACs are still not met, are you gonna take care of this in another branch?: "add backend identity connector in mex-common to get Item.identifier and item.stableTargetID from backend"

@cutoffthetop
Copy link
Contributor Author

Nice, like in code documentation and explanations. But ticket ACs are still not met, are you gonna take care of this in another branch?: "add backend identity connector in mex-common to get Item.identifier and item.stableTargetID from backend"

yes, there's gonna be more branches. but in the backend and extractor repos ;)

@cutoffthetop cutoffthetop merged commit 0760666 into main Nov 3, 2023
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1387-sti-provider branch November 3, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants