fix(js/term_buf): fix broken CSS cursor styling 修正壞掉的游標 CSS 樣式設定 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `)` was accidentally dropped in 8d8db1c "feat(term_buf): webpack require cursor urls".
clearHighlight() resets mouseCursor to 0, so clearHighlight() overrides any previous assignments to mouseCursor. clearHighlight() had only been called when there was a highlighted row, but the precondition had complicated the code and was dropped in b346f46 "Separate more easy reading things.". To fix this issue, the order of mouseCursor assignment and clearHighlight() is simply swapped.
IepIweidieng
changed the title
IepIweidieng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that the dedicated cursor icons are not used.
此 PR 修正專用的游標圖案沒被用到的問題。
fix(js/term_buf): fix missing
)ofurl()for CSS cursor style修正用於 CSS 游標樣式設定的
url()所少了的)The
)was accidentally dropped in the following commit:這個
)在下列 commit 中被不愼移除了：fix(js/term_buf): fix mouseCursor overridden by
clearHighlight()修正
mouseCursor被clearHighlight()（的效果）覆蓋的問題clearHighlight()resetsmouseCursorto0, soclearHighlight()overrides any previous assignments tomouseCursor.clearHighlight()會重設mouseCursor爲0，因此clearHighlight()會覆蓋此前任何賦予mouseCursor的値。clearHighlight()had only been called when there was a highlighted row, but the precondition had complicated the code and was dropped in the following commit:clearHighlight()原只在存在被突出顯示的橫行時才會被呼叫，但此前提條件複雜化了程式碼，而在下列 commit 中去除了：To fix this issue, the order of
mouseCursorassignment andclearHighlight()is simply swapped.爲了解決這個問題，對
mouseCursor的賦値與對clearHighlight()的呼叫的順序已交換。Demostration
The behavior of mouse cursor display after applying this PR:
在套用此 PR 後的滑鼠游標顯示行爲：
Note: For the build in the video, in order to deal with the board-entry screen, I modified
App.prototype.onMouse_click()to send the following keys for mouse actions:注意：在此影片中的程式建構版本中，爲了處理進入看板時的畫面，我修改了
App.prototype.onMouse_click()來對滑鼠動作送出下列按鍵：\12) 重新整理（按畫面左下角；12）: Send ← Enter End End13) 最後同主題（按畫面右下角；13）: Send ← Enter End End [ ]Before applying this PR, only the "I" cursor instead of the dedicated cursor icons is used.
在套用此 PR 前，只有 I 字型游標被使用，而專用的游標圖案沒被用到。