Skip to content

Commit

Permalink
Fix bind host value setup for data service.
Browse files Browse the repository at this point in the history
Add env var HOST to data-service Docker config, as the entrypoint script
requires this in the environment; having this Docker env var be sourced
from a DMOD deployment env var DOCKER_DATA_SERVICE_LISTEN_HOST (or fall
back to default of 0.0.0.0) and adding this new DMOD env var to
example.env.
  • Loading branch information
robertbartel authored and aaraney committed May 13, 2024
1 parent 5734d93 commit b92ca71
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docker/main/docker-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ services:
- SSL_DIR=/ssl/data-service
- OBJECT_STORE_HOST=${DMOD_DATA_SERVICE_OBJ_STORE_HOST:-minio-proxy}
- REDIS_HOST=${DOCKER_REDIS_SERVICE_ALIAS:-myredis}
- HOST=${DOCKER_DATA_SERVICE_LISTEN_HOST:-0.0.0.0}
# computed or optional variables. optional vars have associated default value
# - S3FS_URL_PROTOCOL='http'
# - S3FS_URL_HOST
Expand All @@ -173,7 +174,6 @@ services:
# - S3FS_VOL_IMAGE_TAG='latest'
# - S3FS_PLUGIN_ALIAS='s3fs'
# - S3FS_HELPER_NETWORK='host'
# - HOST # computed with `hostname`
# - REDIS_PORT=6379
# - OBJECT_STORE_PORT=9000
# debugging configuration
Expand Down
3 changes: 3 additions & 0 deletions example.env
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,9 @@ DOCKER_GUI_MAAS_ENDPOINT_HOST=nwm-master_request-service
## The listening port for websocket communication for the dataservice container
DOCKER_DATASERVICE_CONTAINER_PORT=3020

# The bind host value for the service, passed as an arg to uvicorn in the entrypoint script
#DOCKER_DATA_SERVICE_LISTEN_HOST=

## The bound port on the host for the GUI stack web server service container.
## Essentially, this is the port where the application can be accessed.
## This is handled by default in the compose file if not set.
Expand Down

0 comments on commit b92ca71

Please sign in to comment.