Skip to content

Commit

Permalink
holding back coroutines and updating gradle
Browse files Browse the repository at this point in the history
  • Loading branch information
robertfmurdock committed Dec 21, 2024
1 parent 8283243 commit 365bf89
Show file tree
Hide file tree
Showing 13 changed files with 21 additions and 19 deletions.
8 changes: 4 additions & 4 deletions .idea/jsLibraryMappings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ tasks {
clean {
dependsOn(provider { gradle.includedBuilds.map { it.task(":clean") }.toList() })
}
create("versionCatalogUpdate") {
register("versionCatalogUpdate") {
dependsOn(provider { gradle.includedBuilds.map { it.task(":versionCatalogUpdate") }.toList() })
}
register("formatKotlin") {
Expand All @@ -42,7 +42,7 @@ tasks {
val testBuilds = listOf(
gradle.includedBuild("tools"),
)
create<Copy>("collectResults") {
register<Copy>("collectResults") {
dependsOn(provider { (getTasksByName("collectResults", true) - this).toList() })
dependsOn(provider { testBuilds.map { it.task(":collectResults") } })
from(testBuilds.map { it.projectDir.resolve("build/test-output") })
Expand Down
2 changes: 1 addition & 1 deletion command-line-tools/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ tasks {
assemble { dependsOn(provider { (getTasksByName("assemble", true) - this).toList() }) }
check { dependsOn(provider { (getTasksByName("check", true) - this).toList() }) }
clean { dependsOn(provider { (getTasksByName("clean", true) - this).toList() }) }
create("collectResults") {
register("collectResults") {
dependsOn(provider { (getTasksByName("collectResults", true) - this).toList() })
}
register("formatKotlin") {
Expand Down
2 changes: 1 addition & 1 deletion command-line-tools/digger-cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ tasks {
workingDir(mainNpmProjectDir)
commandLine("npm", "publish")
}
val publish by creating {
val publish by registering {
dependsOn(jsPublish)
mustRunAfter(check)
}
Expand Down
2 changes: 1 addition & 1 deletion command-line-tools/tagger-cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ tasks {
check {
dependsOn(confirmTaggerCanRun)
}
val publish by creating {
val publish by registering {
dependsOn(jsPublish)
mustRunAfter(check)
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ plugins {
}

tasks {
val javadocJar by creating(Jar::class) {
val javadocJar by registering(Jar::class, fun Jar.() {
archiveClassifier.set("javadoc")
from("${rootDir.absolutePath}/javadocs")
}
})
publishing.publications {
withType<MavenPublication> { artifact(javadocJar) }
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ tasks {
)

val check by getting
val copyReportsToRootDirectory by creating(Copy::class) {
val copyReportsToRootDirectory by registering(Copy::class) {
mustRunAfter(check)
from("build/reports")
into(projectResultPath)
}
val copyTestResultsToRootDirectory by creating(Copy::class) {
val copyTestResultsToRootDirectory by registering(Copy::class) {
mustRunAfter(check)
from("build/test-results")
into(projectResultPath)
Expand Down
2 changes: 1 addition & 1 deletion tools/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ tasks {
assemble { dependsOn(provider { (getTasksByName("assemble", true) - this).toList() }) }
check { dependsOn(provider { (getTasksByName("check", true) - this).toList() }) }
clean { dependsOn(provider { (getTasksByName("clean", true) - this).toList() }) }
create("collectResults") {
register("collectResults") {
dependsOn(provider { (getTasksByName("collectResults", true) - this).toList() })
}
register("formatKotlin") {
Expand Down
1 change: 1 addition & 0 deletions tools/git-test/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ kotlin {
dependencies {
commonMainImplementation(platform(project(":dependency-bom")))
commonMainImplementation(project(":git-adapter"))
commonMainImplementation(kotlin("stdlib", embeddedKotlinVersion))
commonMainImplementation(kotlin("test"))
commonMainImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-core")
commonMainApi("org.jetbrains.kotlinx:kotlinx-coroutines-test")
Expand Down
3 changes: 2 additions & 1 deletion tools/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
[libraries]
com-benasher44-uuid = "com.benasher44:uuid:0.8.4"
org-jetbrains-kotlinx-kotlinx-coroutines-bom = "org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.10.1"
# @pin
org-jetbrains-kotlinx-kotlinx-coroutines-bom = "org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.9.0"
org-jetbrains-kotlinx-kotlinx-datetime = "org.jetbrains.kotlinx:kotlinx-datetime:0.6.1"
# @pin
org-jetbrains-kotlinx-kotlinx-serialization-bom = "org.jetbrains.kotlinx:kotlinx-serialization-bom:1.6.3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class TaggerPluginTest {
.build()
rootProject.plugins.apply("com.zegreatrob.tools.tagger")
val rootCheck = rootProject.tasks.named("check").get()
val innerProject1Check = innerProject1.tasks.create("check")
val innerProject1Check = innerProject1.tasks.register("check")

val tagTask = rootProject.tasks.findByName("tag")!!

Expand All @@ -40,7 +40,7 @@ class TaggerPluginTest {
)
assertTrue(
tagTask.mustRunAfter.getDependencies(tagTask)
.contains(innerProject1Check),
.contains(innerProject1Check.get()),
"Did not run after inner project check",
)
}
Expand Down

0 comments on commit 365bf89

Please sign in to comment.