Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issues with adding/removing OC's and Season3 #45

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

AnthonyMichaelTDM
Copy link

@AnthonyMichaelTDM AnthonyMichaelTDM commented Jul 1, 2022

What this PR does:

what this PR doesn't do:

notes and acknowledgements

special thanks to @wahlp , who's responses to issue 37 pointed me in the right direction
special thanks to @JairRmz for supplying 20 missing OC GUIDs

for people who want to use this working fork, I direct your attention to, well, my fork

@AnthonyMichaelTDM
Copy link
Author

AnthonyMichaelTDM commented Jul 1, 2022

the reason this PR doesn't rebuild the .zip file is bc the build software this project was built around requires you to purchase a pro license in order to use, which is a problem bc I'm broke

Copy link
Author

@AnthonyMichaelTDM AnthonyMichaelTDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0

@JairRmz
Copy link

JairRmz commented Jul 3, 2022

how can I test this version or any way someone could add it to the ZIP file even manually?

@AnthonyMichaelTDM
Copy link
Author

AnthonyMichaelTDM commented Jul 3, 2022

follow the instructions i added to the readme

basically, clone my fork of the repo, install the required packages w/ pip, and run the project with python

@JairRmz
Copy link

JairRmz commented Jul 4, 2022

ok, from what I tested with my own save adding overclocks works, yet there are still missing some secondaries as pointed in another error for engineer, driller and scout, how could I help on detecting the overclocks?

@AnthonyMichaelTDM
Copy link
Author

ok, from what I tested with my own save adding overclocks works, yet there are still missing some secondaries as pointed in another error for engineer, driller and scout, how could I help on detecting the overclocks?

honestly, I'm still trying to figure that out, but if you have a save with some of the new OCs unforged, send it my way in #46

@JairRmz
Copy link

JairRmz commented Jul 4, 2022

currently crafting every overclock I didnt have, will ignore the OC that arent on the list

@AnthonyMichaelTDM
Copy link
Author

thanks

@Sclhum
Copy link

Sclhum commented Jul 4, 2022

Attempts to use "pip" result in invalid syntax?

@JoshuaAng10
Copy link

Attempts to use "pip" result in invalid syntax?

you need to download powershell, and run the powershell terminal from the file. Then follow the instructions and it should work. Also, make sure python has pip installed. If u still have questions, drop me a DM on discord Joshua#3257, will see if I can help you

@Sclhum
Copy link

Sclhum commented Jul 9, 2022

I am sorry for being stupid, I figured it out. Works perfectly, A+ script.

@Omega172
Copy link

Save.txt
Here is a save with only some of the cosmetic forge items

@Sclhum
Copy link

Sclhum commented Jul 24, 2022

I know there's a way to change the hexadecimal of other cosmetics to change them into other cosmetics (I changed to get the Head Honcho hat), maybe there's a way you can merge that method with this save editor?
(Context: https://www.youtube.com/watch?v=9sBAuFtL1x8)

@JairRmz
Copy link

JairRmz commented Jul 24, 2022

I know there's a way to change the hexadecimal of other cosmetics to change them into other cosmetics (I changed to get the Head Honcho hat), maybe there's a way you can merge that method with this save editor? (Context: https://www.youtube.com/watch?v=9sBAuFtL1x8)

tbf that method doesnt work without already having a skin/cosmetic that you can change the guid value to, therefore it wouldnt be recommended since creating an instance on the .exe that selects a specific item to edit would make it tiresome, I have tried adding skins before but it wasnt working due to how the items are saved, which kinda follow the same issue with overclocks from what I had tested

@AnthonyMichaelTDM
Copy link
Author

I know there's a way to change the hexadecimal of other cosmetics to change them into other cosmetics (I changed to get the Head Honcho hat), maybe there's a way you can merge that method with this save editor? (Context: https://www.youtube.com/watch?v=9sBAuFtL1x8)

as @JairRmz said, it would be possible, but due to the shear quantity of ingame cosmetics it would be a very difficult endeavor for very little gain, and probably outside of the scope of this project

@RapanMasta
Copy link

here is a save with different cosmetics and overclocking
ID_Player.zip

do not import winreg on linux
I just figured out that I can change a setting to allow people to open issues on this repo, updated readme to reflect that
@Kit-Harder
Copy link

Hello.
I seem to have a trouble understanding with the instructions, a more detailed explanation on it would do.

I did everything I could on trying to follow the instructions but with no progress
image_2022-07-31_222303377
I downloaded the source code but I'm clueless on the second part on how to do that

I am aware that I need python in order for it to work but I tried searching how to use python but I spent 5 hours watching and reading on it yet I still have no idea what im doing

Can anyone help me with this? I know its too much to ask but I just want to know if i can add Overclocks to my save files or not

@AnthonyMichaelTDM
Copy link
Author

AnthonyMichaelTDM commented Jul 31, 2022

You could open an issue on my repository, but a simple google search gives you this https://www.groovypost.com/howto/open-command-window-terminal-window-specific-folder-windows-mac-linux/

If you're on windows, you're going to want to open command prompt maybe(?), and you can get python and pip from the windows store I think
Another simple google search of "how to run a python project" yields this: https://stackoverflow.com/questions/12873542/how-to-run-a-python-project

@Kit-Harder
Copy link

You could open an issue on my repository, but a simple google search gives you this https://www.groovypost.com/howto/open-command-window-terminal-window-specific-folder-windows-mac-linux/

If you're on windows, you're going to want to open command prompt maybe(?), and you can get python and pip from the windows store I think Another simple google search of "how to run a python project" yields this: https://stackoverflow.com/questions/12873542/how-to-run-a-python-project

I finally got it to work, Thank so much!

@ajm0208
Copy link

ajm0208 commented Oct 25, 2022

I get through everything until the last step where I input the command and it says "Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases." I have already tried doing the paths solution, the setting solution, restarting my computer, reinstalling python, and none of them seem to work. Every time I end up with the same error. Any one have any ideas?

@AnthonyMichaelTDM
Copy link
Author

I suggest following the instructions and running the python command without arguments

@ajm0208
Copy link

ajm0208 commented Oct 27, 2022

I suggest following the instructions and running the python command without arguments

I don't know how to do that. Searching it up just brings up the things I already tried.

@AnthonyMichaelTDM AnthonyMichaelTDM changed the title Fix issue with adding/removing OC's Fixes for issues with adding/removing OC's and Season3 Nov 3, 2022
@AnthonyMichaelTDM
Copy link
Author

updated for season 3

@RisingArmechadon
Copy link

currently crafting every overclock I didnt have, will ignore the OC that arent on the list

How do I add overclocks? It doesnt work for me

@amogusenjoyee
Copy link

I tried to add my overclocks to the secondary but it appears as forged and it doesn't show up in the equipment section, how do i fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.