Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayNode #2

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix ArrayNode #2

merged 1 commit into from
Dec 12, 2019

Conversation

bboure
Copy link
Contributor

@bboure bboure commented Dec 12, 2019

Hi,

Thanks again for starting this, this is package really useful.

Here are few fixes for issues I came across:

  • Empty arrays should just be resolved as empty arrays

  • Fix an issue with multiple arguments in the logger not being output
    e.g.: super.log('Eval:', 'foo/bar'); => foo/bar was not printed.

  • Added some defaults when params/resolvers are not passed

I also removed

"type": "module",

from package.json as I was always getting this error:

Warning: require() of ES modules is not supported.

This package does not seem to be modular anyway.
Let me know if you feel this is wrong.

If you want to have a look at how I use this package, please have a look here.

@robessog robessog merged commit a3fd14c into robessog:master Dec 12, 2019
@robessog
Copy link
Owner

Thank you for the PR and the fixes. The code change looks good to me and you even covered the empty array case with unit test which is awesome.

@bboure
Copy link
Contributor Author

bboure commented Dec 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants