Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

267 integrate yolo in mast algorithm #2

Merged
merged 21 commits into from
Nov 6, 2020

Conversation

robin-maillot
Copy link
Owner

Changed package to be able to build from repo or clone (read readme for more info).

Warning: The code currently uses a quick and dirty solution in setup.py that consists of:

  • Creating a folder named yolov5-nanovare
  • Copy all modules (.py files into that folder)
  • Replace all local module imports with prepended yolov5-nanovare

Very dirty but currently works (probably a package that can do this for us later).

NOTE: Since only .py files are copied this may lead to issues (other files can be added on case by case if needed)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @robin-maillot, thank you for submitting a PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • Verify all Continuous Integration (CI) checks are passing.
  • Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@vnoblet-nanovare vnoblet-nanovare merged commit f6eca9a into master Nov 6, 2020
@robin-maillot robin-maillot deleted the 267_integrate_yolo_in_mast_algorithm branch November 6, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants