Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Info saving #48

Closed
martinwag opened this issue Jan 25, 2017 · 3 comments
Closed

Device Info saving #48

martinwag opened this issue Jan 25, 2017 · 3 comments
Assignees
@robincornelius

Comments

@martinwag
Copy link
Contributor

martinwag commented Jan 25, 2017 •
edited
Loading

Hi,

when saving info page to .eds/xml, some info is not exported/saved.

Field: ok in .eds export; saved in .xml
Product number yes no
Vendor number yes no

Description yes no
Creation Date/Time no yes (auto filled)
Modification D/T no yes (auto filled)
Modified by yes no
Baudrates yes no
Device settings yes no

I've had a go at fixing this, but wasn't too successfull at finding all the neccessary places in the code. I'm more into embedded systems that GUI design :-)
@martinwag
Copy link
Contributor Author

I've tried this using GIT 8f9e796

@robincornelius
Copy link
Owner

I'll take a look at those fields, They were saving at one point so probably a regression as things were moved and updated.

The git link you pasted is one to an old commit of mine?

@martinwag
Copy link
Contributor Author

Right now, it's the most recent commit.

@robincornelius robincornelius self-assigned this Jan 31, 2017
robincornelius added a commit that referenced this issue Jan 31, 2017
@robincornelius
First pass work at #48
0603ce3 
I think the following now works in both eds and xml

Product number
Vendor number
Description
Creation Date/Time
Modification Date/Time
Modified by

New fields in xml have appropriate uint/byte types not string. String was used for compatibility with CanOpen Nodes original OD editor

the following caveats exist with date time :

In the EDS file the storage format is on two lines one for date and one for time, the format MUST be  DS306 format that is
time- h:mmtt
date- MM-dd-yyyy

XML also stores in same format one field for time one for date

Internally it is stored as a datetime.

When you type and update it uses the DateTime.parse() function so it should support normal local datetime input.

It may crash, it attempts to always parse in a try() but we will see
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robincornelius robincornelius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robincornelius @martinwag