Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let GitHub Actions test for PHP 8.0 #29

Merged
merged 3 commits into from
Dec 6, 2020

Conversation

bepsvpt
Copy link
Contributor

@bepsvpt bepsvpt commented Dec 5, 2020

This pull request updates:

  1. test for PHP 8.0
  2. update actions/checkout and actions/cache version

actions/cache is following https://github.com/shivammathur/setup-php#cache-composer-dependencies format.

@bepsvpt
Copy link
Contributor Author

bepsvpt commented Dec 5, 2020

It seems the deprecated warning is caused by older version of phpbench/phpbench.

I think tests will pass after #28 is merged.

@robinvdvleuten
Copy link
Owner

@bepsvpt could you rebase this PR now that 8.0 support is merged.

@bepsvpt
Copy link
Contributor Author

bepsvpt commented Dec 6, 2020

Hi @robinvdvleuten,

Am I correctly rebasing the master branch?

@robinvdvleuten
Copy link
Owner

@bepsvpt yes that's correct, thank you!

@robinvdvleuten robinvdvleuten merged commit 691bfc1 into robinvdvleuten:master Dec 6, 2020
@robinvdvleuten
Copy link
Owner

@bepsvpt thank you for the effort 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants