Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synch with CPAN 2.0016 and remove use of apostrophe as package separator. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

demerphq
Copy link

@demerphq demerphq commented Feb 9, 2023

This PR includes two patches. The first synchronizes the repo with the CPAN version as referenced in #21

The second removes use of apostrophe as a package separator. In perl 5.37.8 this was marked as deprecated and in perl 5.40.0 it will be removed outright. I also bumped the version to 2.0017.

In 5.40.0 we will remove support for apostrophe as a package separator
entirely, and in 5.37.8 we marked it as deprecated so it will warn.

This patch removes its use from lib/DBM/Deep.pm and bumps the version
to 2.0017
@demerphq
Copy link
Author

demerphq commented Feb 9, 2023

See also Perl/perl5#20781

@demerphq demerphq changed the title Yves/remove apostrophe as package sep Synch with CPAN 2.0016 and remove use of apostrophe as package separator. Feb 9, 2023
@demerphq
Copy link
Author

Note that because DBM::Deep enables fatal warnings this package is broken as 5.37.8. This patch (or one like it) must be merged and released or the module will break when 5.38 is released.

pld-gitsync pushed a commit to pld-linux/perl-DBM-Deep that referenced this pull request Jul 7, 2023
@thoke
Copy link

thoke commented Sep 1, 2023

Any chance of getting this merged and released? With the release of 5.38.0, I'm seeing the issue that is fixed here with the change from $warnings'Offsets to $warnings::Offsets.

@zmughal
Copy link

zmughal commented Sep 1, 2023

Any chance of getting this merged and released? With the release of 5.38.0, I'm seeing the issue that is fixed here with the change from $warnings'Offsets to $warnings::Offsets.

@DrHyde has a development release out https://metacpan.org/release/DCANTRELL/DBM-Deep-2.0016_001/changes.

@DrHyde
Copy link
Contributor

DrHyde commented Sep 2, 2023

That dev release seemed to be OK so I've now pushed out 2.0017, which has a fix for the perl4 package separator problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants