Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling #113

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Refactor error handling #113

merged 5 commits into from
Sep 29, 2023

Conversation

robo9k
Copy link
Owner

@robo9k robo9k commented Sep 28, 2023

Partially implements #112

CookieDatabaseError might not be needed if the foo<P: AsRef<Path>>(&self, filenames: &[P]) were e.g. validated with a TryInto for DatabaseFilePaths.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (f954fec) 41.69% compared to head (bec91ae) 37.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   41.69%   37.23%   -4.47%     
==========================================
  Files           2        2              
  Lines         506      564      +58     
  Branches      506      564      +58     
==========================================
- Hits          211      210       -1     
- Misses        289      350      +61     
+ Partials        6        4       -2     
Files Coverage Δ
src/ffi.rs 47.87% <18.75%> (-5.07%) ⬇️
src/lib.rs 31.91% <17.39%> (-4.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: robot9001 <robo9k@symlink.io>
Signed-off-by: robot9001 <robo9k@symlink.io>
…ic!`

Signed-off-by: robot9001 <robo9k@symlink.io>
…ror`

Signed-off-by: robot9001 <robo9k@symlink.io>
Signed-off-by: robot9001 <robo9k@symlink.io>
@robo9k
Copy link
Owner Author

robo9k commented Sep 29, 2023

I'm don't have a good idea how to test the high- and medium-level code with the real libmagic below. Especially the assertions are hopefully only theoretical.

Postponing this and thus test coverage for whenever.

@robo9k robo9k marked this pull request as ready for review September 29, 2023 01:14
@robo9k robo9k merged commit f0a24af into main Sep 29, 2023
13 of 15 checks passed
@robo9k robo9k deleted the refactor-error-handling branch September 29, 2023 01:15
@robo9k robo9k mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant