Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing requirements files in robocorp-code folder for contribution #1033

Closed
otemek opened this issue Feb 8, 2024 · 2 comments
Closed

missing requirements files in robocorp-code folder for contribution #1033

otemek opened this issue Feb 8, 2024 · 2 comments
Labels
bug Something isn't working robotframework-ls

Comments

@otemek
Copy link
Contributor

otemek commented Feb 8, 2024

Describe the bug
According to the instructions in Contribution guide about preparing code/environment either on Windows or Linux, there are missing requirements files (test/dev) which I guess are required to install and know what packages we need :)

...
python -m pip install -r robocorp-code/tests/test_requirements.txt
python -m pip install -r robocorp-code/dev_requirements.txt
...

Can I ask for some clarification/update on what the requirements are?

@otemek otemek added bug Something isn't working robotframework-ls labels Feb 8, 2024
@fabioz
Copy link
Collaborator

fabioz commented Feb 9, 2024

Thanks for the heads up (the page really needs an update as robocorp-code changed to use pyproject.toml with poetry).

For the Robot Framework Language Server you should be able to change those 2 lines for:

cd robotframework-ls
python setup.py install
pip install -r tests/test_requirements.txt
cd ..

The other lines should still be valid. As a note, you can always refer to how things work in github actions:

https://github.com/robocorp/robotframework-lsp/blob/master/.github/workflows/tests-robotframework-lsp.yml

p.s.: PRs to fix the docs welcome ;)

otemek added a commit to otemek/robotframework-lsp that referenced this issue Feb 9, 2024
fabioz pushed a commit that referenced this issue Feb 10, 2024
@otemek
Copy link
Contributor Author

otemek commented Feb 11, 2024

closing as (at least for now) some part of the contribution documentation was updated. thanks

@otemek otemek closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working robotframework-ls
Projects
None yet
Development

No branches or pull requests

2 participants