Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh binder, update jupyter_lsp spec with install instructions #331

Merged
merged 10 commits into from
Apr 22, 2021

Conversation

bollwyvl
Copy link
Contributor

Hello there!

This hoists the binder config back up to root, and updates the spec to be detected by jupyter_lsp.

It's testable here: Binder

I've also updated the spec to not gobble up plain, as it's causing issues over on https://github.com/krassowski/jupyterlab-lsp/pull/493 because we kinda had the assumption under test that nobody would take it (whoops) and added the install instructions, which would propagate to our docs. There's a spot for extensions, so it could be nice to add robocop there.

It may also be worth looking at some other stuff in setup.py, like aligning the trove classifiers (which show up on PyPI) and the python_requires (which newer pips obey) to have a consistent story.

Anyhow, the binder feels pretty good: selenium stuff works (with headlessfirefox, didn't try too hard to get chromium working), debugger works, robocop works. Not blocking here, but hopefully we'll have a robotkernel soon which supports RF4 (which still has some nice interactive features over xeus-python)... and hopefully a working tests on jupyterlab-lsp! If the notebook issue can be resolved, then we could probably take the spec management burden off of this repo altogether!

@fabioz fabioz merged commit 41f5988 into robocorp:master Apr 22, 2021
@fabioz
Copy link
Collaborator

fabioz commented Apr 22, 2021

Just merged. Thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants