refresh binder, update jupyter_lsp spec with install instructions #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
This hoists the binder config back up to root, and updates the spec to be detected by jupyter_lsp.
It's testable here:
I've also updated the spec to not gobble up
plain
, as it's causing issues over on https://github.com/krassowski/jupyterlab-lsp/pull/493 because we kinda had the assumption under test that nobody would take it (whoops) and added theinstall
instructions, which would propagate to our docs. There's a spot for extensions, so it could be nice to addrobocop
there.It may also be worth looking at some other stuff in
setup.py
, like aligning the trove classifiers (which show up on PyPI) and thepython_requires
(which newer pips obey) to have a consistent story.Anyhow, the binder feels pretty good: selenium stuff works (with
headlessfirefox
, didn't try too hard to getchromium
working), debugger works, robocop works. Not blocking here, but hopefully we'll have arobotkernel
soon which supports RF4 (which still has some nice interactive features over xeus-python)... and hopefully a working tests onjupyterlab-lsp
! If the notebook issue can be resolved, then we could probably take the spec management burden off of this repo altogether!