Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SS positioning may make the machine inaccessible #2

Closed
morxa opened this issue Aug 23, 2018 · 7 comments
Closed

SS positioning may make the machine inaccessible #2

morxa opened this issue Aug 23, 2018 · 7 comments
Assignees
@thomerz
Labels
bug Something isn't working
Milestone
RoboCup 2019

Comments

@morxa
Copy link
Member

morxa commented Aug 23, 2018

The positioning of the SS is buggy. It allows the SS to be positioned such that it is facing the wall, therefore the machine is inaccessible.
@morxa
Copy link
Member Author

morxa commented Aug 23, 2018

I'm actually not sure which way it is: @chde Is the SS accessed from the input or from the output side?

@morxa morxa added the bug Something isn't working label Aug 23, 2018
@chde
Copy link

chde commented Aug 24, 2018

Currently only output side, but could/should be both sides for outgoing goods. Mid-term we should allow teams to store items.

@thomerz
Copy link

thomerz commented Sep 4, 2018

We discussed this in today's TC meeting. I already updated the gecode file such that both input and output side of a SS need to be blocked. I will file a pull-request after testing my changes.

@thomerz thomerz self-assigned this Sep 4, 2018
@morxa
Copy link
Member Author

morxa commented Jan 28, 2019

The required rule change to block both sides was proposed in robocup-logistics/rcll-rulebook#11.

@morxa
Copy link
Member Author

morxa commented Apr 16, 2019

@thomerz What's the status here? Could you file a PR for your changes?

@morxa morxa added this to the German Open 2019 milestone Apr 16, 2019
@thomerz
Copy link

thomerz commented Apr 28, 2019

@morxa sorry I am quite busy at the moment since we have an upcoming EU review on Mon/Tue. I will file the PR on Tuesday on my way to Magdeburg.

@morxa morxa modified the milestones: German Open 2019, RoboCup 2019 May 28, 2019
@morxa
Copy link
Member Author

morxa commented Jun 7, 2019

Fixed in #28

@morxa morxa closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomerz thomerz

Labels
bug Something isn't working
Projects
None yet
Milestone
RoboCup 2019
Development

No branches or pull requests
3 participants
@thomerz @morxa @chde