Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage station requires free input and output sides #11

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

thomerz
Copy link

@thomerz thomerz commented Sep 4, 2018

Similar to other MPS types (besides DS), SS should block zones at input and output side, respectively. DS block their input side only since no product can be fetched from a DS.

@thomerz thomerz requested a review from a team as a code owner September 4, 2018 13:41
@thomerz thomerz force-pushed the SS-blocks-input-output branch from a552e1a to 802d023 Compare September 5, 2018 12:38
morxa
morxa previously approved these changes Oct 5, 2018
MostafaGomaa
MostafaGomaa previously approved these changes Oct 31, 2018
@morxa
Copy link
Member

morxa commented Oct 31, 2018

This needs to be rebased due to changes merged from #16. Do you want me to do that?

timn
timn previously requested changes Nov 16, 2018
Copy link
Member

@timn timn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo fixes.

rulebook.tex Outdated Show resolved Hide resolved
rulebook.tex Outdated Show resolved Hide resolved
Similar to other MPS types (besides DS), SS should block zones at
input and output side, respectively. DS block their input side only
since no product can be fetched from a DS.
@morxa morxa dismissed stale reviews from MostafaGomaa and themself via 42b63ab January 15, 2019 14:05
@morxa morxa force-pushed the SS-blocks-input-output branch from 802d023 to 42b63ab Compare January 15, 2019 14:05
@thomerz thomerz requested a review from dka14 as a code owner January 15, 2019 14:05
@morxa
Copy link
Member

morxa commented Jan 15, 2019

This needs to be rebased due to changes merged from #16. Do you want me to do that?

I rebased onto the latest master.

Co-Authored-By: Tim Niemueller <niemueller@kbsg.rwth-aachen.de>
@morxa morxa dismissed timn’s stale review January 15, 2019 16:32

I added all suggested edits

@morxa morxa self-requested a review January 15, 2019 17:42
@morxa
Copy link
Member

morxa commented Jan 15, 2019

+1

Copy link
Member

@timn timn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, document artifact in builds is legible.

@timn
Copy link
Member

timn commented Jan 16, 2019

+1

2 similar comments
@MostafaGomaa
Copy link
Member

+1

@dka14
Copy link
Contributor

dka14 commented Jan 21, 2019

+1

@morxa
Copy link
Member

morxa commented Jan 30, 2019

Proposal accepted

  • in favor: 2
  • abstentions: 0
  • opposed: 0

@morxa morxa merged commit 141c51a into master Jan 30, 2019
@morxa morxa deleted the SS-blocks-input-output branch January 30, 2019 10:15
@morxa morxa added accepted-rule-change The rule change has been accepted and removed vote-in-progress labels Feb 14, 2019
@morxa morxa added this to the RoboCup 2019 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted-rule-change The rule change has been accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants