Simplify field setup through less useless randomization #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ring costs are randomized anyways, hence it does not matter if color assignments are randomized as well. Since it is easier to setup the field when the colors remain constant, keep them constant.
snoato
reviewed
Apr 19, 2022
|
+1 |
TarikViehmann
force-pushed
the
tviehmann/simplify-randomization
branch
from
04bd87a to
9d681c5
Compare
snoato
previously approved these changes
Apr 19, 2022
|
+1 |
snoato
approved these changes
Apr 21, 2022
TarikViehmann
added
accepted-rule-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses 2 out of the 3 points of issue #44 by fixing both the arrangement of pre-stored products at the storage station and the assignment of ring colors to ring stations in games of the main track.
Since the discussion about the primary field halve lead to no consent yet, i will open a separate issue for that to be addressed next season.
Also, while scrolling through the issues i noticed issue #27, which is also addressed here.
So this PR fixes #27 and fixes #44.
The technical changes in the refbox are proposed in robocup-logistics/rcll-refbox#121.