add rule regarding pre-stored products in main track #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoato
reviewed
Apr 19, 2022
|
+1 |
Co-authored-by: Daniel Swoboda <swoboda@kbsg.rwth-aachen.de>
|
+1 |
1 similar comment
|
+1 |
snoato
approved these changes
Apr 21, 2022
TarikViehmann
added
accepted-rule-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was no mention of pre-stored products after the changes to a new order schedule.
My simple proposal is to allow at most 1 pre-stored C0 to be used for now. That is consistent with the old ruling, where it could only be used for one order.