Merge pull request #829 from roboflow/feature/make-turn-config-optional

Make TURN server config optional
roboflow · Nov 22, 2024 · 33b17f2 · 33b17f2
2 parents 89caeb4 + 5fe9f4c
commit 33b17f2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/inference/core/interfaces/stream_manager/manager_app/entities.py b/inference/core/interfaces/stream_manager/manager_app/entities.py
@@ -99,7 +99,7 @@ class WebRTCTURNConfig(BaseModel):
 
 class InitialiseWebRTCPipelinePayload(InitialisePipelinePayload):
     webrtc_offer: WebRTCOffer
-    webrtc_turn_config: WebRTCTURNConfig
+    webrtc_turn_config: Optional[WebRTCTURNConfig] = None
     stream_output: Optional[List[str]] = Field(default_factory=list)
     data_output: Optional[List[str]] = Field(default_factory=list)
     webrtc_peer_timeout: float = 1

diff --git a/inference/core/interfaces/stream_manager/manager_app/webrtc.py b/inference/core/interfaces/stream_manager/manager_app/webrtc.py
@@ -228,15 +228,20 @@ async def init_rtc_peer_connection(
         webcam_fps=webcam_fps,
     )
 
-    turn_server = RTCIceServer(
-        urls=[webrtc_turn_config.urls],
-        username=webrtc_turn_config.username,
-        credential=webrtc_turn_config.credential,
-    )
-    peer_connection = RTCPeerConnectionWithFPS(
-        video_transform_track=video_transform_track,
-        configuration=RTCConfiguration(iceServers=[turn_server]),
-    )
+    if webrtc_turn_config:
+        turn_server = RTCIceServer(
+            urls=[webrtc_turn_config.urls],
+            username=webrtc_turn_config.username,
+            credential=webrtc_turn_config.credential,
+        )
+        peer_connection = RTCPeerConnectionWithFPS(
+            video_transform_track=video_transform_track,
+            configuration=RTCConfiguration(iceServers=[turn_server]),
+        )
+    else:
+        peer_connection = RTCPeerConnectionWithFPS(
+            video_transform_track=video_transform_track,
+        )
     relay = MediaRelay()
 
     @peer_connection.on("track")