Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim Docker Images #178

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Slim Docker Images #178

merged 1 commit into from
Dec 8, 2023

Conversation

paulguerrie
Copy link
Contributor

Description

Created new docker files for slim images that don't have core model deps.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

probicheaux
probicheaux reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@probicheaux probicheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! looks like you're removing pip cache but it may be simpler to never add stuff there in the first place

docker/dockerfiles/Dockerfile.onnx.cpu.slim Show resolved Hide resolved
@paulguerrie paulguerrie merged commit fd86b8d into main Dec 8, 2023
5 checks passed
@paulguerrie paulguerrie deleted the feature/slim-docker-images branch December 8, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probicheaux probicheaux Awaiting requested review from probicheaux probicheaux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulguerrie @probicheaux