Emable SSL on Redis connection based on env config (to enable AWS lambda connectivity) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bda connectivity)
paulguerrie
approved these changes
Dec 27, 2023
PawelPeczek-Roboflow
deleted the
fix/remove_issues_with_redis_connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To connect to AWS elasticache it's required to use basic SSL context in Redis Client (as per all examples and empirical tests executed). In this PR, I've made SSL mode configurable via env with default being
use SSLfor lambda images, and not use SSL in other modes (for now, as SSL does not work with our default cache solutions deployed locally).List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
NA
Docs