Add port forward to Notebook Landing Page message #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run docker with notebook enabled on notebook landing page
hansent
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby and
probicheaux
as code owners
PawelPeczek-Roboflow
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you start inference server without
NOTEBOOK_ENABLEDthe notebook link on the landing page goes to a page that instructs you to tun the docker image with added flag-e NOTEBOOK_ENABLED=trueHowever without also forwarding the port 9002 via
-p 9002:9002flag, the result is just a broken page that doesnt load. This just adds that flag to the message.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
locally
Any specific deployment considerations
I ran npm run build in
inference/landingbut didn't commit the build output files since there seemed to be more changes but see e.g. thatinference/landing/out/notebook-instruction is commited in the repo. So instead just added the small change to those build output files directly (to avoid having to do these manual(?) changes again.Docs
n/a