Fixing the bug with two stage workflow and continue-if failing when nothing gets detected by primary model #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelPeczek-Roboflow
requested review from
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
grzegorz-roboflow
approved these changes
Nov 6, 2024
PawelPeczek-Roboflow
deleted the
fix/issue_with_2_step_workflow_and_continue_if
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a bug in the following setup:
object detection -> crop -> classification -> [downstream step],for any downstream block we could not correctly construct empty Batches of inputs whenever nothing was detected by primary model. Turned out to be stupid bug.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs