Return single top class confidence for mulit-label predictions #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyGavrilenko
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
EmilyGavrilenko
commented
Nov 6, 2024
| for class_name in predicted_classes | ||
| ] | ||
| if not predicted_confidences: | ||
| return 0.0 |
There was a problem hiding this comment.
I'm returning 0.0 instead of None because subsequent UQL operations (such as top_class_confidence_single >= 0.5) fail if None is returned
There was a problem hiding this comment.
yeah, I am think in general about Maybe[X] monad to be good idea for UQL
PawelPeczek-Roboflow
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a UQL operation to return the single top class confidence for multi-label predictions
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
2 new unit tests
Any specific deployment considerations
linked to this frontend PR
Docs
n/a