Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detections_to_coco_annotations function for empty polygons. #1086

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
73 changes: 50 additions & 23 deletions supervision/dataset/formats/coco.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import os
from datetime import datetime
from pathlib import Path
from typing import Dict, List, Tuple
from typing import Dict, List, Optional, Tuple

import cv2
import numpy as np
Expand Down Expand Up @@ -97,6 +97,28 @@ def coco_annotations_to_detections(
return Detections(xyxy=xyxy, class_id=np.asarray(class_ids, dtype=int))


def object_to_coco(
Youho99 marked this conversation as resolved.
Show resolved Hide resolved
xyxy: np.ndarray,
class_id: int,
annotation_id: int,
image_id: int,
polygon: Optional[np.ndarray] = None,
) -> dict:
box_width, box_height = xyxy[2] - xyxy[0], xyxy[3] - xyxy[1]

coco_annotation = {
"id": annotation_id,
"image_id": image_id,
"category_id": int(class_id),
"iscrowd": 0,
"bbox": [xyxy[0], xyxy[1], box_width, box_height],
"area": box_width * box_height,
"segmentation": [] if polygon is None else [polygon.reshape(-1)],
}

return coco_annotation


def detections_to_coco_annotations(
detections: Detections,
image_id: int,
Expand All @@ -105,31 +127,36 @@ def detections_to_coco_annotations(
max_image_area_percentage: float = 1.0,
approximation_percentage: float = 0.75,
) -> Tuple[List[Dict], int]:
coco_annotations = []
annotation = []
for xyxy, mask, _, class_id, _, _ in detections:
box_width, box_height = xyxy[2] - xyxy[0], xyxy[3] - xyxy[1]
polygon = []
if mask is not None:
polygon = list(
approximate_mask_with_polygons(
mask=mask,
min_image_area_percentage=min_image_area_percentage,
max_image_area_percentage=max_image_area_percentage,
approximation_percentage=approximation_percentage,
)[0].flatten()
polygons = approximate_mask_with_polygons(
mask=mask,
min_image_area_percentage=min_image_area_percentage,
max_image_area_percentage=max_image_area_percentage,
approximation_percentage=approximation_percentage,
)
coco_annotation = {
"id": annotation_id,
"image_id": image_id,
"category_id": int(class_id),
"bbox": [xyxy[0], xyxy[1], box_width, box_height],
"area": box_width * box_height,
"segmentation": [polygon] if polygon else [],
"iscrowd": 0,
}
coco_annotations.append(coco_annotation)
annotation_id += 1
return coco_annotations, annotation_id
for polygon in polygons:
if polygon.any(): # polygon not empty
next_object = object_to_coco(
xyxy=xyxy,
Youho99 marked this conversation as resolved.
Show resolved Hide resolved
class_id=class_id,
annotation_id=annotation_id,
image_id=image_id,
polygon=polygon,
)
annotation.append(next_object)
annotation_id += 1
else:
next_object = object_to_coco(
xyxy=xyxy,
class_id=class_id,
annotation_id=annotation_id,
image_id=image_id,
)
annotation.append(next_object)
annotation_id += 1
return annotation, annotation_id


def load_coco_annotations(
Expand Down