Allow "tiff" and more extensions in DetectionDataset.from_yolo
function
#1636
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1554 as discussed with @LinasKo.
Highlights
DetectionDataset.from_yolo
.Tested extensions (listed on Ultralytics predict page):
Pillow
could not readpfm
images,cv2
is able to read them. I saw here that even Ultralytics usesPillow
to read images. In that case, I am not sure if Ultralytics can "really" supportpfm
format, as their documentation suggests.ValueError
otherwise.List any dependencies that are required for this change.
Pillow
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
The changes are tested with this colab notebook.
Test Case
100 images of each extension were generated along with their corresponding dummy labels and dummy
data.yml
. Test run checks if the function works for a particular extension and computes time taken to load the dataset.Time taken (in seconds) to run the test case
-1.11
value indicates thatsupervision
doesn't support that extension yet.Result for
supervision
version0.24.0
, which usescv2
to check the shape of images.Result for this PR, which uses
Pillow
to check the shape and type (RGB or not) of images.Docs