Skip to content

refactor: split utils across multiple files to increase utils visibility and prevent circular imports #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SkalskiP merged 27 commits into from
Jul 15, 2025
Merged

refactor: split utils across multiple files to increase utils visibility and prevent circular imports #1890

SkalskiP merged 27 commits into from
Jul 15, 2025

Conversation

@SkalskiP
Copy link
Collaborator

@SkalskiP SkalskiP commented Jul 15, 2025 •
edited
Loading

Description

  • utils split across multiple files
  • internal and external imports working
  • utils tests split across multiple files
  • tests working locally
  • works with Python 3.9
  • docs updated

@SkalskiP
utils split across multiple files; internal and external imports work…
fa5fcbb 
…ing; utils tests split across multiple files; tests working locally
@SkalskiP SkalskiP requested a review from onuralpszr as a code owner July 15, 2025 17:25
@SkalskiP SkalskiP requested a review from soumik12345 July 15, 2025 18:05
SkalskiP and others added 12 commits July 15, 2025 20:10
@SkalskiP
make sure only recently updated pages have new status
5b42be9
@SkalskiP
Merge remote-tracking branch 'origin/refactor/split_detection_utils_t…
873f249 
…o_prevent_circular_imports_and_increase_utils_visibility' into refactor/split_detection_utils_to_prevent_circular_imports_and_increase_utils_visibility
@SkalskiP
mark from_lmm as deprecated in docs
ab9d128
@onuralpszr
fix: 🐞 type annotations for internal.py vars
b8d646a
@pre-commit-ci
fix(pre_commit): 🎨 auto format pre-commit hooks
3ba5c12
@onuralpszr
docs: 📝 add docstring to validate_vlm_parameters
8710bde
@onuralpszr
fix: 🐞 correct possessive form in docstring for LMM and VLM enums
334d8e6
@SkalskiP
added mask_non_max_merge to quick imports
2dca99d
@SkalskiP
Merge remote-tracking branch 'origin/refactor/split_detection_utils_t…
f9cdb93 
…o_prevent_circular_imports_and_increase_utils_visibility' into refactor/split_detection_utils_to_prevent_circular_imports_and_increase_utils_visibility
@pre-commit-ci
fix(pre_commit): 🎨 auto format pre-commit hooks
facc64b
@soumik12345
fix: formula in box_iou docstring
14d3b79
@pre-commit-ci
fix(pre_commit): 🎨 auto format pre-commit hooks
1bc672a
soumik12345
soumik12345 previously approved these changes Jul 15, 2025
View reviewed changes
SkalskiP added 2 commits July 15, 2025 20:55
@SkalskiP
fix latex problems
d854e23
@SkalskiP
Merge remote-tracking branch 'origin/refactor/split_detection_utils_t…
0a33334 
…o_prevent_circular_imports_and_increase_utils_visibility' into refactor/split_detection_utils_to_prevent_circular_imports_and_increase_utils_visibility

# Conflicts:
#	supervision/detection/utils/iou_and_nms.py
@onuralpszr onuralpszr requested a review from soumik12345 July 15, 2025 18:58
@SkalskiP SkalskiP merged commit 5c1a5ea into develop Jul 15, 2025
21 checks passed
@Borda Borda deleted the refactor/split_detection_utils_to_prevent_circular_imports_and_increase_utils_visibility branch January 7, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumik12345 soumik12345 Awaiting requested review from soumik12345

1 more reviewer

@onuralpszr onuralpszr onuralpszr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SkalskiP @onuralpszr @soumik12345