Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sv.BlurAnnotator #395 #405

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Conversation

Rajarshi-Misra
Copy link
Contributor

@Rajarshi-Misra Rajarshi-Misra commented Oct 4, 2023

Description

Created sv.BlurAnnotator. The code contain a BlurAnnotator class which contains function to blur annotate the detections.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

YOUR_ANSWER

Any specific deployment considerations

The docs might require update due to the new annotator class

Docs

  • Docs updated? What were the changes:

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@Rajarshi-Misra Rajarshi-Misra marked this pull request as ready for review October 4, 2023 12:55
@hardikdava hardikdava changed the title New1 sv.BlurAnnotator Oct 4, 2023
@hardikdava
Copy link
Collaborator

@Rajarshi-Misra Please accept and sign CLA so we can start review it. Please update description of PR and link related issues.

@Rajarshi-Misra Rajarshi-Misra changed the title sv.BlurAnnotator Create sv.BlurAnnotator #395 Oct 4, 2023
@Rajarshi-Misra
Copy link
Contributor Author

@hardikdava I've made the suggested changes and signed the CLA

@hardikdava hardikdava self-requested a review October 4, 2023 13:14
@SkalskiP SkalskiP added api:annotator Annotators hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti enhancement New feature or request labels Oct 4, 2023
@SkalskiP SkalskiP self-requested a review October 4, 2023 14:36
@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 4, 2023

Hi, @Rajarshi-Misra! 👋🏻 Thanks a lot for your interest in supervision! 🔥

We try to make annotators accessible for users like this:

import supervision as sv

blur_annotator = sv.BlurAnnotator()

To make this happen you need to add an import of BlurAnnotator in the main file __init__.py. Try to locate this import:

from supervision.annotators.core import (
    BoundingBoxAnnotator,
    BoxCornerAnnotator,
    CircleAnnotator,
    EllipseAnnotator,
    LabelAnnotator,
    MaskAnnotator,
    TraceAnnotator,
)

And make it:

from supervision.annotators.core import (
    BoundingBoxAnnotator,
    BoxCornerAnnotator,
    BlurAnnotator,
    CircleAnnotator,
    EllipseAnnotator,
    LabelAnnotator,
    MaskAnnotator,
    TraceAnnotator,
)

@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 4, 2023

@Rajarshi-Misra I also encountered this error when I tried to run BlurAnnotator:

error: OpenCV(4.8.0) :-1: error: (-5:Bad argument) in function 'GaussianBlur'
> Overload resolution failed:
>  - GaussianBlur() missing required argument 'src' (pos 1)
>  - GaussianBlur() missing required argument 'src' (pos 1)

Take a look at this colab: https://colab.research.google.com/drive/1GuG1yiiiw5knJOy-fhuGkhtjqLNkjMvE?usp=sharing

@SkalskiP SkalskiP linked an issue Oct 4, 2023 that may be closed by this pull request
@Rajarshi-Misra
Copy link
Contributor Author

I'll resolve the error as soon as possible

@Rajarshi-Misra
Copy link
Contributor Author

@SkalskiP I've resolved the issue and committed to the branch. This is a result for your reference.
image

@SkalskiP SkalskiP added the hacktoberfest-accepted Contribute to the notion of open-source this October! label Oct 4, 2023
@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 4, 2023

@Rajarshi-Misra and @hardikdava, awesome work! I'll include it in our release tomorrow! 🔥

@SkalskiP SkalskiP merged commit 3a52f7b into roboflow:develop Oct 4, 2023
4 checks passed
@onuralpszr onuralpszr added the version: 0.15.0 Feature to be added in `0.15.0` release label Oct 4, 2023
@onuralpszr onuralpszr added this to the version: 0.15.0 milestone Oct 4, 2023
@SkalskiP
Copy link
Collaborator

SkalskiP commented Oct 4, 2023

@Rajarshi-Misra, I want to include you in the release social media post tomorrow. Could out lin here your LinkedIn and Twitter?

@Rajarshi-Misra
Copy link
Contributor Author

Rajarshi-Misra commented Oct 5, 2023

Twitter: @rajistalking
LinkedIn: https://www.linkedin.com/in/rajarshi-misra-b1142a1b7
@SkalskiP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:annotator Annotators enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti hacktoberfest-accepted Contribute to the notion of open-source this October! version: 0.15.0 Feature to be added in `0.15.0` release
Projects
Status: Current Release: Done
Development

Successfully merging this pull request may close these issues.

Create sv.BlurAnnotator
5 participants