-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added box mask annotators #422
Conversation
@SkalskiP The document needs to be updated. Can you handle that? |
@onuralpszr Can you review this? |
Hi, @hardikdava 👋🏻! I'll take a look now. |
color=color.as_bgr(), | ||
thickness=-1, | ||
) | ||
scene = cv2.addWeighted( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardikdava we merge "faster" mask PR so we should replace that cv2.addWeighted this that code so it can be faster as well for start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR link : #426
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could that be relevant in the context of this PR as well #426 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SkalskiP yes
btw, @hardikdava you know that you can create branches directly in |
@onuralpszr and @hardikdava I updated the docs and tested them. It works. Should we merge it and go back if people complain about performance in the future? |
Okay merge it. I also have different approach for performance I was thinking and we can always improve more too. |
Description
This PR is related to #421
List any dependencies that are required for this change.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Docs