generated from roboflow/template-python
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sv.dot marker annotator #396 #492
Merged
SkalskiP
merged 5 commits into
roboflow:develop
from
PankajKrana:Create_sv.DotMarkerAnnotator_#396
Oct 18, 2023
Merged
Create sv.dot marker annotator #396 #492
SkalskiP
merged 5 commits into
roboflow:develop
from
PankajKrana:Create_sv.DotMarkerAnnotator_#396
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.
Hi, @PankajKrana 👋🏻 could you accept the CLA agreement? |
The DotMarkerAnnotator class has been refactored and named DotAnnotator for simplicity. It's now part of the core annotators to conform with the project structure. The color lookup on the DotAnnotator now uses the 'color_lookup' parameter, allowing for more flexibility and customization in the colors used for the annotations. All the changes aim to standardize the way different annotators are organized and make color customization easier.
Hi, @PankajKrana 👋🏻! Thanks a lot for your contribution 🙏🏻 Merging! |
SkalskiP
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api:annotator
Annotators
enhancement
New feature or request
hacktoberfest
Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses issue #396.
List any dependencies that are required for this change.
Type of change
This feature implements the sv.DotMarkerAnnotator in the Supervision library. The DotMarkerAnnotator is designed to mark objects related to sv.Detections with dots. It allows the user to choose a color palette and a color mapping strategy, including options such as index, class, or track. The position of the dot in relation to the box can also be controlled using sv.Position.
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
Any specific deployment considerations
if any changes need suggest me