Skip to content
tests

Remove generic arguments for read and write buffer. #185

Sign in to view logs

Remove generic arguments for read and write buffer.

Remove generic arguments for read and write buffer. #185

GitHub Actions / clippy succeeded Jan 1, 2025 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 439 in src/bus/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the loop variable `i` is only used to index `buffer2` 

warning: the loop variable `i` is only used to index `buffer2`
   --> src/bus/mod.rs:439:12
    |
439 |         for i in 0..buffer2.len() {
    |                  ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
    |
439 |         for <item> in &buffer2 {
    |             ~~~~~~    ~~~~~~~~

Check warning on line 433 in src/bus/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the loop variable `i` is only used to index `buffer1` 

warning: the loop variable `i` is only used to index `buffer1`
   --> src/bus/mod.rs:433:12
    |
433 |         for i in 0..buffer1.len() {
    |                  ^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
    = note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
    |
433 |         for <item> in &buffer1 {
    |             ~~~~~~    ~~~~~~~~

Check warning on line 58 in src/instructions/ping.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions 

warning: very complex type used. Consider factoring parts into `type` definitions
  --> src/instructions/ping.rs:58:28
   |
58 |     pub fn scan(&mut self) -> Result<Vec<Result<Response<Ping>, ReadError<SerialPort::Error>>>, crate::WriteError<SerialPort::Error>> {
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 58 in src/instructions/ping.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions 

warning: very complex type used. Consider factoring parts into `type` definitions
  --> src/instructions/ping.rs:58:28
   |
58 |     pub fn scan(&mut self) -> Result<Vec<Result<Response<Ping>, ReadError<SerialPort::Error>>>, crate::WriteError<SerialPort::Error>> {
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default
View more details on GitHub Actions