Better logging

roboll · Aug 6, 2019 · fcbd682 · fcbd682
1 parent bbc2931
commit fcbd682
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/pkg/helmexec/exec.go b/pkg/helmexec/exec.go
@@ -132,14 +132,17 @@ func (helm *execer) List(context HelmContext, filter string, flags ...string) (s
 }
 
 func (helm *execer) DecryptSecret(context HelmContext, name string, flags ...string) (string, error) {
-	helm.decryptedSecretMutex.Lock()
+
+	var secret *decryptedSecret
 
 	absPath, err := filepath.Abs(name)
 	if err != nil {
 		return "", err
 	}
 
-	var secret *decryptedSecret
+	helm.logger.Debugf("Waiting for cache mutext for secret %v", absPath)
+	helm.decryptedSecretMutex.Lock()
+	helm.logger.Debugf("Cache mutex for secret %v acquired", absPath)
 
 	// Cache miss
 	if _, ok := helm.decryptedSecrets[absPath]; !ok {
@@ -179,11 +182,11 @@ func (helm *execer) DecryptSecret(context HelmContext, name string, flags ...str
 
 	} else {
 		// Cache hit
-		helm.logger.Debugf("Using cached secret %v", absPath)
+		helm.logger.Debugf("Found secret in cache %v", absPath)
 
 		secret = helm.decryptedSecrets[absPath]
-		helm.decryptedSecretMutex.Unlock()
 		secret.mutex.RLock()
+		helm.decryptedSecretMutex.Unlock()
 		defer secret.mutex.RUnlock()
 	}