-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helmfile lint+template command try to fetch local chart in 0.119.1 #1328
Comments
@mumoshu @roboll Can you guys look at this? I just tried the latest 0.123.0 and this issue still exists:
|
Why does helmfile not see that this is a local chart? It starts with a forward slash. Again, 0.114 is ok. |
@Morriz Feeling interesting that I can't reproduce this. I have Could you confirm that /tmp/charts/base is readable to your user? |
@mumoshu I am having this issue also. I did not even have a
I also don't see where
|
@tinyzimmer Thanks! Helmfile do use Re: why this might be happening, Helmfile runs a lengthy logic to detect if it needs to be fetched. If the string specified in Lines 870 to 871 in 14636e3
Maybe there're edge-cases that logic doesn't work as expected? Do you have any insight? |
@mumoshu I'm not near the stuff I was working on at the moment, but I had eventually figured it out. And if I recall correctly, it was having the local paths quoted in the |
I just did a quick poke through that package. Is this potentially the cause? https://github.com/roboll/helmfile/blob/master/pkg/state/util.go#L10
This would go against my understanding of how yaml works 😛, but if the quotes are part of the string when that's getting evaluated then that regex wouldn't match. EDIT: I actually can't for the life of me reproduce this right now. I was almost positive it had to do with the quotes in the end, but I can't validate that theory at the moment. For whatever it's worth, the chart in question had dependent charts that had not been built yet. I tried recreating that situation and then running a
I'll update later if I have any success reproducing again. |
I create these folders in a pre hook, so they don't exist beforehand. This worked up till the version I mentioned though. Something changed |
@Morriz Thank you so much for the info! That does help. It turns out we accidentally changed the meaning of I'll fix it asap. Thanks again for your patience and support. |
In #1172, we accidentally changed the meaning of prepare hook that is intended to be called BEFORE the pathExists check. It broke the scenario where one used a prepare hook for generating the local chart dynamically. This fixes Helmfile not to fetch local chart generated by prepare hook. In addition to that, this patch results in the following fixes: - Fix an issue that `helmfile template` without `--skip-deps` fails while trying to run `helm dep build` on `helm fetch`ed chart, when the remote chart has outdated dependencies in the Chart.lock file. It should be up to the chart maintainer to update Chart.lock and the user should not be blocked due to that. So, after this patch `helm dep build` is run only on the local chart, not on fetched remote chart. - Skip fetching chart on `helmfile template` when using Helm v3. `helm template` in helm v3 does support rendering remote charts so we do not need to fetch beforehand. Fixes #1328 May relate to #1341
In #1172, we accidentally changed the meaning of prepare hook that is intended to be called BEFORE the pathExists check. It broke the scenario where one used a prepare hook for generating the local chart dynamically. This fixes Helmfile not to fetch local chart generated by prepare hook. In addition to that, this patch results in the following fixes: - Fix an issue that `helmfile template` without `--skip-deps` fails while trying to run `helm dep build` on `helm fetch`ed chart, when the remote chart has outdated dependencies in the Chart.lock file. It should be up to the chart maintainer to update Chart.lock and the user should not be blocked due to that. So, after this patch `helm dep build` is run only on the local chart, not on fetched remote chart. - Skip fetching chart on `helmfile template` when using Helm v3. `helm template` in helm v3 does support rendering remote charts so we do not need to fetch beforehand. Fixes #1328 May relate to #1341
I use hooks to create tmp charts, but when I try to install those like this, it tries to fetch them and fails:
Error:
This happens in version 0.119.1 but I had this working fine before in 0.114.0.
The text was updated successfully, but these errors were encountered: