Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Secrets under environments #255

Closed
mumoshu opened this issue Aug 30, 2018 · 2 comments
Closed

feat: Secrets under environments #255

mumoshu opened this issue Aug 30, 2018 · 2 comments

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Aug 30, 2018

Extracted from #59 (comment)

Enhance #253 to accept secrets: under each environment:

environments:
  production:
  values:
  - environments/production/values.yaml
  secrets:
  - environments/production/secrets.yaml

releases:
- name: myapp
  values:
  - values.yaml.gotmpl

So that contents of values.yaml and decrypted secrets.yaml are merged and then can be referenced from within values.yaml.gotmpl.

@mumoshu mumoshu changed the title feat: Add secrets under environments feat: Secrets under environments Aug 30, 2018
mumoshu added a commit to mumoshu/helmfile that referenced this issue Aug 31, 2018
mumoshu added a commit to mumoshu/helmfile that referenced this issue Sep 2, 2018
mumoshu added a commit that referenced this issue Sep 2, 2018
@Xtigyro
Copy link

Xtigyro commented Feb 5, 2020

@mumoshu If this is applied - will the secrets coming from HashiCorp Vault be suppressed too?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Feb 5, 2020

This feature is not about suppressing secrets from being printed. But yes, --suppress-secrets should prevent any k8s secret from being printed regardless of where the source is(vault, ssm, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants