Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--args parsing does not support flags #457

Open
jrnt30 opened this issue Jan 26, 2019 · 3 comments
Open

--args parsing does not support flags #457

jrnt30 opened this issue Jan 26, 2019 · 3 comments

Comments

@jrnt30
Copy link
Contributor

jrnt30 commented Jan 26, 2019

Currently with the implementation of the args parsing fails to pass args that are the short version of the flag due to the -- check. For instance helmfile template --args "-x templates/ingress.yaml" will not pass down the -x arg.

Not the end of the world but was unexpected.

@frank-berlin
Copy link

This hole logic is unclear why it needed.
also use case where multiple templates should be rendered don't work:

-e staging template --args --set frank=true  --execute templates/clusterrole.yaml  --execute templates/clusterrolebinding.yaml  --execute templates/role.yaml  --execute templates/rolebinding.yaml  --execute templates/scoped-clusterrole.yaml  --execute templates/scoped-clusterrolebinding.yaml --set rbac.create=true

result in:

--set frank=true --set rbac.create=true --execute templates/clusterrole.yaml

why is args not saved as string and simple appended?

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 25, 2019

@frank-berlin (If I remember correctly) The whole logic was there to allow merging --args from the command-line and args from your helmfile.yaml. In that sense, it would be good to just concatenating both args as simple strings.

Does simple string concatenation works as we would expect? Like the latter flag values(from command-line) overrides the values from the ones passed via --arsg?

@frank-berlin
Copy link

frank-berlin commented Mar 25, 2019

Yes would work I think.
That helm see this as additional parameter in same order as supplied.
Then also quoting will work, what it not right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants