-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass-thru options for helmfile template #1060
Comments
It appears |
I noticed there's a |
@mumoshu I could use an option for
is a problem, because I need it for |
We're trying to deprecate |
@travisghansen Do you need those options to be configurable within |
Maybe |
@Nuru Sorry but I don't know how I'd use |
@mumoshu If we want to manage CRDs some other way than with the helm chart we are using to install the program,
|
@Nuru Thanks! Gotcha. So you would probably like to use it from a command-line arg, like |
Yeah I’m only using template: https://github.com/travisghansen/argo-cd-helmfile/blob/master/src/argo-cd-helmfile.sh |
@mumoshu On the contrary, I would primarily use it in the helmfile.yaml, because it is part of how I am managing the release of the chart. "For this chart, I am manually managing CRDs, so skip CRDs for the chart." That is why I mentioned |
@mumoshu This is a bigger problem than I thought, because I cannot use |
I'd like to throw out there Maybe something like this could work (as an easier substitute before a better solution)?
|
Just like @travisghansen, I was working on integrating Helmfile with ArgoCD, using CustomTool approach of the later to dynamically render results of the Helmfile. @travisghansen has provided a great script to make that work here, however the Api Versions capabilities do not work, as helm template command expects stringArray of --api-versions command line flag while script is currently passing comma-separated set of versions via single flag I tried to fork the repository and update bash script logic to pass multiple --api-versions flags in the --args parameter of the helmfile, but now problems seems to be that helmfile is not correctly working with mutiple parameters specified using the same key (as described in #457 ) So my current solution to dynamically feed helmfile, invoked via ArgoCD, with apiversions of target cluster is using the new apiVersions section (described in doc under Advanced Configuration: API Capabilities) and requiring the ArgoCD parameter to be set:
|
@GolubevV could you open an issue up on my project as well to discuss and possibly fix however best we can currently? |
@travisghansen - I can make a PR with a fix to the script that will change behaviour to provide each K8S APi version with a separate dedicated flag. However, that would not fix the problem completely as some change in the helmfile logic is required to perform correct support for multiple flags with the same key value (--api-versions), provided either via --args or helmDefaults.args to be proxied down to helm template command. Currently, it looks like only the first argument is used, while all others are just dropped ( as described in issue 457 comment) @mumoshu - For that problem, i am not sure if that should be tracked in this issue, issue #457 or should i create a completely new one? |
Just to add some more usecases into the pot. I'm trying to pass |
Thanks for the great tool! Trying to best leverage
helmfile
in a gitops situation (specifically looking atargo-cd
ATM) and found a few options that would be helpful to pass through tohelm
:--no-hooks
--skip-crds
--api-versions
I'm not sure exactly how
--api-versions
versions is meant to be used, meaning, not sure if it can be specified multiple times, or once with comma-separate values or what.Thanks!
#1014 (comment)
The text was updated successfully, but these errors were encountered: