bug: HelmState.scatterGather ignores item parameter

[travisgroth]

Came across this in #782

See

helmfile/pkg/state/state_run.go

Lines 15 to 20 in bce2f47

	numReleases := len(st.Releases)
	if concurrency < 1 {
	concurrency = numReleases
	} else if concurrency > numReleases {
	concurrency = numReleases
	}

It looks like the intention was to make that method generic and be informed of the number of items coming in, but it seems to default/max against the number of releases instead.

This may be the first/only non-release based usage. It would be good to re-use it for environment secrets.

My proposal is to use the items parameter, which is currently unused. Can put in a PR if that makes sense.

[mumoshu]

@travisgroth Wow! Good catch.

Yeah items should be used instead of len(st.Releases) when concurrency isn't specified(0).

To be extra clear, I believe it should be:

 if concurrency < 1 { 
 	concurrency = items 
 } else if concurrency > items { 
 	concurrency = items 
 } 

Or even just:

 if concurrency < 1 || concurrency > items { 
 	concurrency = items 
 }

Btw concurrency > items is there to cap concurrency to number of items. This isn't strictly needed, but for avoiding unnecessary/redundant goroutines.

I'd appreciate it if you could submit a PR 😄