-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmfile installs non-existent release version #815
Comments
@Nuru Good catch! It does sound like a bug. If you could have some time to work on this, would you try adding some code to remove the directory at Line 220 in a584aea
Perhaps that's the only thing needed to fix it. |
something like this should work:
|
Sorry, @mumoshu, I don't have a golang build environment to build and test with. |
@Nuru Got it 👍I just reproduced this myself. Will fix it asap. |
Bug in helmfile version v0.81.0
At the time of this writing, the latest release of
cloudposse/helmfiles
is 0.58.0. There is no 0.59.0 release. However, this happened:In other words, the first time I tried to install the non-existent release, it failed, as it should. However,
helmfile
apparently created a.helmfile/cache/https_github_com_cloudposse_helmfiles_git.ref=0.59.0
directory and populated it with the latest release or current master branch (they are currently the same commit) of the repo. Then the second time I ran the command,helmfile
found the cache and went ahead an installed it.This lead to the wrong version of helmfiles being installed without warning.
Please fix this. If the tag does not exist, then the cache directory should not be created and populated, or at least it should be deleted when the error is detected.
The text was updated successfully, but these errors were encountered: