feat: helmfile build --embed-values to embed release values and secrets into the output
#1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rets into the output
I don't think it's a problem for the terraform plugin, as it's only used for the diff cache SHA calculation and is not printed anywhere, right? |
mnatan
reviewed
Aug 28, 2020
| } | ||
|
|
||
| if len(paths) > 1 { | ||
| return nil, fmt.Errorf("glob patterns in release values and secrets is not supported yet. please submit a feature request if necessary") |
@mnatan Thanks for reviewing ❤️ Yes, I think you're correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handy when debugging complex
helmfile.yamlandvalues.yaml.gotmplas the resultinghelmfile.yamlcontains all the rendered values and sops-encrypted secrets in its embedded form.It's gonna be used to resolve a terraform-provider-helmfile issue that requires a unique hash of the desired state: mumoshu/terraform-provider-helmfile#28
Environment values and secrets are not yet supported. They are output as-is. But it should be fine as the resulting helm release won't change as long as release values/secrets are unchanged.