feat: Stabilize helmfile-diff output #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finishes the work started at #1619 by introducing the following changes: - You can now set `HELMFILE_TEMPDIR` and `CHARTIFY_TEMPDIR` as the directory to persist temporary values files rendered by helmfile and temporary charts generated by chartify. Note that chartify is used internally when you use kustomize integration or raw K8s manifests as a chart. - Helmfile uses the hash sum of the release config and the values file content in the file name of the temporary values file. In combination with `HELMFILE_TEMPDIR` and `CHARTIFY_TEMPDIR`, this enables helmfile to use the stable file names for temporary values files, which contribute to stabilize log messages like `Comparing release=appset, chart=PATH/TO/TEMPORARY/CHART`, where the `PATH/TO/TEMPORARY/CHART` had been randomized due to formerly random helmfile tempdir and temporary values file names, and random chartify tempdir. You can try this feature with a script like: ``` tempdir=$(mktemp -d -t helmfile) HELMFILE_TEMPDIR=${tempdir} CHARTIFY_TEMPDIR=${tempdir} helmfile diff rm -rf ${tempdir} ```
mumoshu
added a commit
to mumoshu/terraform-provider-helmfile
that referenced
this pull request
Jan 1, 2021
so that helmfile-diff output becomes stables and terraform plan doesn't break. See roboll/helmfile#1622 for more information.
mumoshu
added a commit
to mumoshu/terraform-provider-helmfile
that referenced
this pull request
Jan 1, 2021
so that helmfile-diff output becomes stables and terraform plan doesn't break. See roboll/helmfile#1622 for more information.
|
@mumoshu what's the default temp dir location if |
|
@dudicoco Depends on what |
|
@mumoshu I've used Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes the work started at #1619 by introducing the following changes:
You can now set
HELMFILE_TEMPDIRandCHARTIFY_TEMPDIRas the directory to persist temporary values files rendered by helmfile and temporary charts generated by chartify. Note that chartify is used internally when you use kustomize integration or raw K8s manifests as a chart.Helmfile uses the hash sum of the release config and the values file content in the file name of the temporary values file.
In combination with
HELMFILE_TEMPDIRandCHARTIFY_TEMPDIR, this enables helmfile to use the stable file names for temporary values files, which contribute to stabilize log messages likeComparing release=appset, chart=PATH/TO/TEMPORARY/CHART, where thePATH/TO/TEMPORARY/CHARThad been randomized due to formerly random helmfile tempdir and temporary values file names, and random chartify tempdir.You can try this feature with a script like: