Fix/secrets ordering #1723
Closed
Fix/secrets ordering #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I've created some integration test infra for helm-secrets testing as a prerequisite to fix secrets ordering in helmfile. Secrets ordering is broken since #790
Vagrantfileto be able to run integration tests locally in similar environmentTODOs:
I need some help to fix the issue with helmfile secrets handling: it should fail when secrets decryption fails (or the result produced might be incorrect). Right now it does not (I know about this issue for a long time). Here is the test run to show that: https://app.circleci.com/pipelines/github/astorath/helmfile/34/workflows/6a533209-b1cf-4d47-bb22-9daf80d48691/jobs/153/parallel-runs/0/steps/0-110
I need some guide on where should I fix the issue (the code is a bit messy in secrets handling for me).