Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/secrets rc #1724

Merged
merged 23 commits into from
Mar 23, 2021
Merged

Fix/secrets rc #1724

merged 23 commits into from
Mar 23, 2021

Conversation

astorath
Copy link
Contributor

Hey!

I've created some integration test infra for helm-secrets testing as a prerequisite to fix secrets ordering in helmfile. Secrets ordering is broken since #790

  1. Moved integration provisioning to Makefile to reuse some code
  2. Added Vagrantfile to be able to run integration tests locally in similar environment
  3. Made some fixes to make integration tests reusable
  4. Added some simple secrets handling tests
  5. Fixed issue when helmfile ignored secrets decrypting errors

Note: this includes #1721

@astorath astorath mentioned this pull request Mar 16, 2021
@mumoshu
Copy link
Collaborator

mumoshu commented Mar 23, 2021

Resolved conflict with #1721

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work @astorath 👍

@mumoshu mumoshu merged commit db9d31a into roboll:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants