Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --output-dir on template command #693

Merged
merged 1 commit into from
Jul 11, 2019
Merged

feat: add --output-dir on template command #693

merged 1 commit into from
Jul 11, 2019

Conversation

olivierboudet
Copy link
Contributor

Resolves #629

@mumoshu mumoshu mentioned this pull request Jun 16, 2019
Closed
@olivierboudet
Copy link
Contributor Author

Hello @mumoshu ,

I have added a unit test. Can you check if it looks OK ?

mumoshu
mumoshu approved these changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks a lot for your efforts @olivierboudet 👍

pkg/helmexec/exec.go Outdated Show resolved Hide resolved
feat: add --output-dir on template command
6d9c743 
generate templates in a subdirectory named "stateFileName-stateFileHash-releaseName"
@mumoshu mumoshu merged commit 2f9f520 into roboll:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --output-dir to the helmfile template command
2 participants
@olivierboudet @mumoshu