Shared helmexec for Environment Secrets #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@travisgroth Thanks again for your efforts. #800 has been just merged so please feel free to make this a non-draft PR once this is ready to be reviewed 👍 |
travisgroth
force-pushed
the
feat/state-level-secret-cache
branch
from
32da549
to
e77d74e
Compare
mumoshu
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
LGTM. Thanks a lot for your efforts and contributions, @travisgroth 👍 💯
|
Any time. Glad to help out @mumoshu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444 and #782
This is the final PR to fully cache and parallelize helm secret decryption. It threads the shared helmexec.Interface into the StateCreator and HelmState structs to be used during environment secret decryption. This should effectively cache secrets for the duration of a helmfile run, regardless of where they are first decrypted.
This is based on the work in #800, so it is draft until that PR is final.