-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update documentation about layering release values #837
Conversation
@a-hat Hey! Thanks for your support. This part of the documentation specifically explain how |
Hi @mumoshu! After reading the documentation I tried something like this (note the
which gives me these errors:
Is the documentation referring to something else which I am missing? |
@a-hat Btw, in your example you don't need
|
Fix apache thrift location issue (roboll#835)
I see, thanks for the clarification. I was using version 0.81.3, so this is why I updated the PR and left the section about layering |
@a-hat Thanks! Would you mind prepending The statements are correct. I believe it should reside within a dedicated section though. |
Thanks for your feedback! Makes sense, I have updated the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for your contribution @a-hat
setTemplate
andvaluesTemplate
do not work, I think it is correct without theTemplate
suffix.I also added a note to the documentation regarding this issue #836