-
Notifications
You must be signed in to change notification settings - Fork 52
Closed
Description
Current Workflow (Manual)
When I commit frequently, roborev creates many review jobs. Before running roborev fix --unaddressed, I manually:
- Check each finding to see if it's still valid (some are false positives due to limited context)
- Copy findings to Claude to cross-check with wider code search
- Consolidate related findings across multiple reviews
- Only then decide what to actually fix
Proposed Solution
Add roborev compact --unaddressed to automate this verification and consolidation step.
Behavior
roborev compact --unaddressed- Finds all unaddressed completed review jobs
- For each finding: agent performs wide code search to verify it's still present
- Filters out false positives
- Consolidates related findings across reviews into one review
- Creates a new consolidated review job
- Marks original jobs as addressed
Command Interface
roborev compact [flags]
Flags:
--unaddressed compact all unaddressed completed jobs
--agent string agent to use for verification (default: from config)
--branch string filter by branch (default: current branch)
--all-branches include jobs from all branchesWhy This Helps
- Adds verification layer before applying fixes
- Reduces noise from false positives
- Consolidates findings for easier human review
- Fits naturally between
reviewandfixin the workflow
What I have checked
- I did look at discussion in RFC: Refine Single Commit from TUI #130. I believe for
roborevto be helpful it is better that after we have done focus work with a string of commits we need lesser number of agent-reviews to review before trying to refine. Refining 20 commits one by one is not practical - This support editing review before copy #98 suggests that others also want to refine the reviews before applying them
- This batch copy support batch-commit copy #100 is also something that feels like is basically going out of roborev so we can manually review the reviews
- Add functionality to edit review to cherry pick review points #227 Again brings up the point of not using all the review points
Open to feedback on command name and interface!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels