Fix hook test portability and robustness #182
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add -Encoding UTF8 to Set-Content in pwdCmd for Windows PS 5.1 - Use exact path comparison on Unix, case-insensitive only on Windows - Add t.Cleanup safety net for logger restoration in log tests - Fix stale shellEscape doc comment (now single quotes on all platforms) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Set-Content -Encoding UTF8 writes a BOM on PS 5.1. Use [IO.File]::WriteAllText which writes UTF-8 without BOM. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-Encoding UTF8toSet-ContentinpwdCmdto avoid UTF-16LE on Windows PowerShell 5.1EqualFoldonly on Windowst.Cleanupsafety net for logger restoration in log capture testsshellEscapedoc comment to reflect single-quote behaviorTest plan
🤖 Generated with Claude Code