Add --batch flag to roborev fix #185
Merged
+518
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concatenates multiple review findings into a single prompt so an agent addresses all issues in one pass instead of sequential single-job runs. Supports explicit job IDs (--batch 123 124) or auto-discovery of unaddressed jobs (--batch with no args). Reviews are greedily packed into batches respecting max prompt size config. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests buildBatchFixPrompt (multi-entry, single-entry), splitIntoBatches (fits-in-one, splitting, oversized-solo, empty, order preservation), formatJobIDs, and --batch/--unaddressed mutual exclusion validation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Reject --branch/--all-branches/--newest-first with explicit batch IDs - Fix size accounting mismatch: extract shared batchPromptHeader, batchPromptFooter, and batchEntrySize so splitIntoBatches and buildBatchFixPrompt use identical sizing - Add test asserting built prompt respects size estimate - Expand flag validation tests for all --batch mutual exclusions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Recompute entrySize with index 1 after starting a new batch, so the size estimate matches the actual prompt position. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
I used this on a batch of 15 reviews and it worked fantastically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--batchflag toroborev fixthat concatenates multiple review findings into a single agent prompt, so all issues are addressed in one pass instead of sequential single-job runsroborev fix --batch 123 124 125batches listed jobs;roborev fix --batchauto-discovers unaddressed jobs on the current branchconfig.ResolveMaxPromptSize()(default 200KB); oversized single reviews get their own batch--branch,--all-branches,--newest-first(discovery mode only)--branch/--all-branches/--newest-firstwhen explicit job IDs are providedTest plan
go build ./...passesgo test ./...passesbuildBatchFixPrompt(multi-entry, single-entry)splitIntoBatches(fits-in-one, splitting, oversized-solo, empty, order, size-limit assertion)formatJobIDs--batchmutual exclusionsroborev fix --batchwith 2+ unaddressed jobs concatenates into single prompt🤖 Generated with Claude Code